Dan Kenigsberg has submitted this change and it was merged. Change subject: Make networking API endpoints match schema ......................................................................
Make networking API endpoints match schema There used to be non-optional parameters with default values. And not only that, the default values were mutable which is bad. Patch Set 2: - Rebased. Change-Id: Ifee2318b89f190bffa4c8db65eae7839d21a3d29 Signed-off-by: Antoni S. Puimedon <asegu...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/15482 Reviewed-by: Giuseppe Vallarelli <gvall...@redhat.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M vdsm/API.py M vdsm/BindingXMLRPC.py M vdsm/configNetwork.py M vdsm/supervdsmServer.py 4 files changed, 21 insertions(+), 11 deletions(-) Approvals: Giuseppe Vallarelli: Looks good to me, but someone else must approve Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifee2318b89f190bffa4c8db65eae7839d21a3d29 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Adam Litke <a...@us.ibm.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
