Dan Kenigsberg has posted comments on this change. Change subject: Hidden bonds[1/2]: Adding a test to cover the current implementation of nics(). ......................................................................
Patch Set 2: I would prefer that you didn't submit this (2 inline comments) .................................................... File tests/netinfoTests.py Line 144: Line 145: try: Line 146: self.assertEqual(set(netinfo.nics()), Line 147: set(['em', 'me', 'fake0', 'fake'])) Line 148: except: isn't except-raise redundant? Line 149: raise Line 150: finally: Line 151: # teardown test fixture Line 147: set(['em', 'me', 'fake0', 'fake'])) Line 148: except: Line 149: raise Line 150: finally: Line 151: # teardown test fixture the code is self-explanatory. I love comments, but not when the code is so simple. -- To view, visit http://gerrit.ovirt.org/16238 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idde9ce51025e97c176ffa95aa0f81bcbc639f96f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
