Federico Simoncelli has posted comments on this change. Change subject: volume: add the BLOCK_SIZE constant ......................................................................
Patch Set 3: (1 inline comment) .................................................... File vdsm/storage/volume.py Line 95: # At the moment this is static and it has been introduced to group all the Line 96: # previous implicit references to the block size in FileVolume. In the future Line 97: # it will depend on the storage domain. Line 98: BLOCK_SIZE = 512 Line 99: We could but we should add also a new dependency (in all these files) for a module that is not very much used at the moment (and it's almost empty). We'll see if indeed storageConstants is required (looks redundant to me now) and eventually we'll move it there. Line 100: Line 101: def fmt2str(format): Line 102: return FMT2STR[format] Line 103: -- To view, visit http://gerrit.ovirt.org/14589 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia517ec858fb0d7ee45323b7e2a3584c0858222f0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Deepak C Shetty <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
