Ayal Baron has posted comments on this change. Change subject: Remove StoragePool.createVolume(). ......................................................................
Patch Set 1: Do not submit (2 inline comments) .................................................... File vdsm/storage/hsm.py Line 1397: sdDom.validateCreateVolumeParams(volFormat, preallocate, srcVolUUID) Line 1398: Line 1399: vars.task.getSharedLock(STORAGE, sdUUID) Line 1400: imageResourcesNamespace = sd.getNamespace(sdUUID, IMAGE_NAMESPACE) Line 1401: with rmanager.acquireResource(imageResourcesNamespace, imgUUID, This lock will be released as soon as schedule comes back which means that the actual create will not be protected. Line 1402: rm.LockType.exclusive): Line 1403: self._spmSchedule(spUUID, "createVolume_%s" % volUUID, Line 1404: sdDom.createVolume, imgUUID, size, volFormat, Line 1405: preallocate, diskType, volUUID, desc, .................................................... File vdsm/storage/sp.py Line 1894: Line 1895: with rmanager.acquireResource(imageResourcesNamespace, imgUUID, Line 1896: rm.LockType.exclusive): Line 1897: image.Image(self.poolPath).merge( Line 1898: sdUUID, vmUUID, imgUUID, ancestor, successor, postZero) removing the function from here also means you have no guarantee that the task will run when host is spm which is obviously wrong. Line 1899: Line 1900: def deleteVolume(self, sdUUID, imgUUID, volumes, postZero, force): Line 1901: """ Line 1902: Deletes a given volume. -- To view, visit http://gerrit.ovirt.org/16325 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45186ab45d075d764c0a630e6b7a483baef1e45b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Elad Ben Aharon <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
