Deepak C Shetty has posted comments on this change.
Change subject: vdsm-tool: service management work with previous systemd release
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File lib/vdsm/tool/service.py
Line 114: for line in out:
Line 115: if fullName == line.split(" ", 1)[0]:
Line 116: return systemctlFun(fullName)
Line 117: raise ServiceNotExistError("%s is not native systemctl
service" %
Line 118: fullName)
Small suggestion. Since user input is srvName and not fullName, wouldn't it be
better to keep srvName in the error msg instead of fullName ?
Line 119: return wrapper
Line 120:
Line 121: @_systemctlNative
Line 122: def _systemctlStart(srvName):
--
To view, visit http://gerrit.ovirt.org/16379
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice83296bd88ed5bb13630694560cde58b050edbb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
