Giuseppe Vallarelli has posted comments on this change. Change subject: Simplify configWriter to use netmodels ......................................................................
Patch Set 4: I would prefer that you didn't submit this (1 inline comment) See comment. .................................................... File vdsm/netconf/ifcfg.py Line 73: bridge.port.configure(**opts) Line 74: self._addSourceRoute(bridge, ipaddr, netmask, gateway, bootproto) Line 75: ifup(bridge.name, async) Line 76: Line 77: def configureVlan(self, vlan, **opts): I'm ok with using **opts, but we need to document what are the possible options otherwise I would personally not be aware of what options I can pass to configureVlan, this consideration applies also to other different methods. Line 78: ipaddr, netmask, gateway, bootproto, async = vlan.getIpConfig() Line 79: self.configWriter.addVlan(vlan, **opts) Line 80: vlan.device.configure(**opts) Line 81: self._addSourceRoute(vlan, ipaddr, netmask, gateway, bootproto) -- To view, visit http://gerrit.ovirt.org/16324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9e00f6a8ce21a2e0bf24ad2cd13af6fe3d3f356 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
