Zhou Zheng Sheng has uploaded a new change for review. Change subject: PEP8: fix tests/hooksTests.py ......................................................................
PEP8: fix tests/hooksTests.py pep8 1.4.6 gives the following error tests/hooksTests.py:140:23: E127 continuation line over-indented for visual indent tests/hooksTests.py:141:18: E124 closing bracket does not match visual indentation And pep8 1.4.5 on RHEL6 gives the following error vdsm/guestIF.py:30:5: E122 continuation line missing indentation or outdented This patch fixes the errors while makes pep8 1.4.5 and 1.4.6 both agree with the fix. Change-Id: Ib6f8843f7bf9f57c040b4747e89ce90ee6122823 Signed-off-by: Zhou Zheng Sheng <[email protected]> --- M tests/hooksTests.py M vdsm/guestIF.py 2 files changed, 8 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/16424/1 diff --git a/tests/hooksTests.py b/tests/hooksTests.py index 9e65212..001f329 100644 --- a/tests/hooksTests.py +++ b/tests/hooksTests.py @@ -136,9 +136,9 @@ def test_deviceVmConfProperties(self): dirName = self._deviceCustomPropertiesTestFile() - vmconf = {'custom': - {'customProperty': ' rocks more!'} - } + vmconf = { + 'custom': { + 'customProperty': ' rocks more!'}} result = hooks._runHooksDir("oVirt", dirName, params={'customProperty': ' rocks!'}, diff --git a/vdsm/guestIF.py b/vdsm/guestIF.py index 569aa9d..07f9c20 100644 --- a/vdsm/guestIF.py +++ b/vdsm/guestIF.py @@ -25,9 +25,11 @@ import json import supervdsm -__RESTRICTED_CHARS = set(range(8 + 1)).union( - set(range(0xB, 0xC + 1))).union(set(range(0xE, 0x1F + 1))).union( - set(range(0x7F, 0x84 + 1))).union(set(range(0x86, 0x9F + 1))) +__RESTRICTED_CHARS = set(range(8 + 1)). \ + union(set(range(0xB, 0xC + 1))). \ + union(set(range(0xE, 0x1F + 1))). \ + union(set(range(0x7F, 0x84 + 1))). \ + union(set(range(0x86, 0x9F + 1))) def _filterXmlChars(u): -- To view, visit http://gerrit.ovirt.org/16424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib6f8843f7bf9f57c040b4747e89ce90ee6122823 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
