Dan Kenigsberg has posted comments on this change.
Change subject: hooks: Add OpenStack Network vNIC hook
......................................................................
Patch Set 10: Looks good to me, approved
(1 inline comment)
....................................................
File vdsm_hooks/openstacknet/after_device_create.py
Line 30: from openstacknet_consts import DUMMY_BRIDGE
Line 31: from openstacknet_consts import OPENSTACK_NET_PROVIDER_TYPE
Line 32: from openstacknet_consts import PROVIDER_TYPE_KEY
Line 33: from openstacknet_consts import VNIC_ID_KEY
Line 34: from vdsm.constants import EXT_BRCTL
Oh. Too many constants.py.
Line 35:
Line 36:
Line 37: def disconnectVnic(portId):
Line 38: tapName = ('tap' + portId)[:DEV_MAX_LENGTH]
--
To view, visit http://gerrit.ovirt.org/11108
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I744b83d9c6027bd817e5d4171a77a005611b9818
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
