Dan Kenigsberg has posted comments on this change. Change subject: vdsmd.init: do not use previous libvirt logrotate ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) minor suggestion .................................................... File vdsm/vdsmd.init.in Line 406: } Line 407: ## end of configuration section by vdsm Line 408: EOF Line 409: # Backup (comment) original logrotate.d/libvirtd Line 410: /bin/sed -i 's/^/#/' "$llogr" it would be a bit safer to comment out each line with # vdsm so when we remove the comment, we make sure that we do not remove someone else's comment. Line 411: /bin/sed -e "/# vdsm/,/# end vdsm/d" "$llogr" >> "$stanza" Line 412: local oldmod=`/usr/bin/stat --format=%a "$llogr"` Line 413: /bin/mv "$stanza" "$llogr" Line 414: if [ -n "$oldmod" ]; then -- To view, visit http://gerrit.ovirt.org/16528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa9707d892bb03a029300f62ae1ed204cea52486 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
