Timothy Asir has posted comments on this change.
Change subject: gluster: verbs for managing services
......................................................................
Patch Set 23: (3 inline comments)
....................................................
File client/vdsClientGluster.py
Line 691: 'glusterServicesManage': (
Line 692: serv.do_glusterServicesManage,
Line 693: ('serviceNames=<service1[,service2,..]> action=<action> '
Line 694: '[failOnError=<yes|no>]\n\t',
Line 695: 'servicesNames - list of services on which action needs
'
this should be 'serviceNames'
Line 696: 'to be performed',
Line 697: 'action can be start/stop or restart',
Line 698: 'Performs start/stop/restart of gluster services'
Line 699: )),
....................................................
File vdsm/gluster/services.py
Line 127: return _action(serviceNames, action, failOnError)
Line 128:
Line 129:
Line 130: @makePublic
Line 131: def servicesGet(serviceNames, failOnError=False):
yes its sufficient to return the status list. we are not using this flag in
engine also. This failOnError flag can be removed.
Line 132: """
Line 133: {'services': [
Line 134: {'name': SERVICE_NAME, 'status': STATUS, 'message':
MESSAGE},..]}
Line 135: """
....................................................
File vdsm/gluster/vdsmapi-gluster-schema.json
Line 260: # @RUNNING: Service is Running
Line 261: #
Line 262: # @STOPPED: Service is Stopped
Line 263: #
Line 264: # @NOT_AVAILABLE: Service is not managed/available
Yes, We will change this to "Service is not Installed"
Line 265: #
Line 266: # @NOT_SUPPORTED: Service is not allowed to manage
Line 267: #
Line 268: # @ERROR: Service action failed
--
To view, visit http://gerrit.ovirt.org/11094
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a16bf566d17e186a66503391dfd04b2f2bb4bb4
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK <avish...@redhat.com>
Gerrit-Reviewer: Adam Litke <a...@us.ibm.com>
Gerrit-Reviewer: Aravinda VK <avish...@redhat.com>
Gerrit-Reviewer: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
