Antoni Segura Puimedon has posted comments on this change. Change subject: Add bootproto during delNetwork ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/configNetwork.py Line 319: netEnt = objectivizeNetwork(bridge=network if bridged else None, vlan=vlan, Line 320: bonding=bonding, nics=nics, _netinfo=_netinfo, Line 321: configurator=configurator, Line 322: implicitBonding=implicitBonding) Line 323: netEnt.ip.bootproto = _getBootProtocol(netEnt.name) My idea was rather to do it inline (otherwiser _getBootProtocol is a method that belongs more in the netinfo module). Line 324: netEnt.remove() Line 325: # libvirt net removal must be done after removal so that on dhcp ifdown Line 326: # the dhcp hook still sees the network as belonging to vdsm. Line 327: configurator.removeLibvirtNetwork(network) -- To view, visit http://gerrit.ovirt.org/16678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe7c39ed1eeb94e806b168bd346dbcd51abd8ffa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
