Saggi Mizrahi has posted comments on this change.
Change subject: lvm: Enhance lvm performance by using devmapper full path
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File tests/lvmTests.py
Line 31: for c in chars:
Line 32: dev += '\\' + hex(ord(c))[1:4]
Line 33: devs = [dev]
Line 34: filter = lvm._buildFilter(devs)
Line 35: expectedFilter = ("filter = [
\'a%/dev/mapper/a\\\\x20\\\\x24\\\\x7c"
format in the value of dev to prevent silly mistakes.
Line 36: "\\\\x22\\\\x28%\', \'r%.*%\' ]"
Line 37: )
--
To view, visit http://gerrit.ovirt.org/16730
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If92940f132238d90e91c1e9ddfecb68df453e1d8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Marina Kalinin <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
