Mark Wu has uploaded a new change for review. Change subject: vdsm-tool: remove 'vdsm/tool/*.pyc' files on uninstallation ......................................................................
vdsm-tool: remove 'vdsm/tool/*.pyc' files on uninstallation It's found that 'vdsm/tool/*.pyc' files are not removed on uninstallation. It could cause a break after installing a different version vdsm. That's because vdsm-tool tries to load all python modules under vdsm.tool. If the requirements of these old modules can't be sytisfied by the new installed packages, vdsm-tool will abort. This problem is caused by a wrong target type for python files in lib/vdsm/tool. They're not compiled during 'make install' and therefore complied python files are not tracked by rpm. This patch also fixes a wrong target name in CLEANFILES. Change-Id: I5fd67f3fbcbf4c8f72180ba0129b0bc09b20def0 Signed-off-by: Mark Wu <[email protected]> --- M lib/vdsm/tool/Makefile.am 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/16761/1 diff --git a/lib/vdsm/tool/Makefile.am b/lib/vdsm/tool/Makefile.am index 5172593..364b28d 100644 --- a/lib/vdsm/tool/Makefile.am +++ b/lib/vdsm/tool/Makefile.am @@ -25,7 +25,7 @@ validate_ovirt_certs.py.in \ $(NULL) -nodist_vdsmtool_DATA = \ +nodist_vdsmtool_PYTHON = \ load_needed_modules.py \ validate_ovirt_certs.py \ $(NULL) @@ -34,7 +34,7 @@ libvirt_configure.sh \ $(NULL) -dist_vdsmtool_DATA = \ +dist_vdsmtool_PYTHON = \ __init__.py \ dummybr.py \ nwfilter.py \ @@ -47,6 +47,6 @@ CLEANFILES = \ config.log \ - $(nodist_vdsmtool_DATA) \ - $(nodist_vdsmtool_SCRIPTS) \ + $(nodist_vdsmtool_PYTHON) \ + $(nodist_vdsmexec_SCRIPTS) \ $(NULL) -- To view, visit http://gerrit.ovirt.org/16761 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5fd67f3fbcbf4c8f72180ba0129b0bc09b20def0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
