Assaf Muller has posted comments on this change. Change subject: Multiple Gateways[6/2]: Swapped libvirt network & netEnt creation ......................................................................
Patch Set 8: (1 inline comment) .................................................... File vdsm/sourceRoute.py Line 102: @staticmethod Line 103: def addInterfaceTracking(device): Line 104: _, _, _, bootproto, _ = device.getIpConfig() Line 105: if bootproto == 'dhcp': Line 106: open(DynamicSourceRoute.getTrackingFilePath(device.name), 'a').\ I find open(..).close() much more explicit and readable. An empty 'with' block is kind of backwards in my mind... Line 107: close() Line 108: Line 109: @staticmethod Line 110: def removeInterfaceTracking(device): -- To view, visit http://gerrit.ovirt.org/16692 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5af431909427dc7488875f0cb14fe4361657a83 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
