Michal Skrivanek has posted comments on this change. Change subject: vdsm: report migration status in getVMList() call ......................................................................
Patch Set 3: (1 inline comment) .................................................... Commit Message Line 7: vdsm: report migration status in getVMList() call Line 8: Line 9: getVMList() is polled by the engine every 3 sec, so it is not the worst place Line 10: for migration statistics — if VM is in the migration state. Thus, the engine Line 11: will be able to track migration progress without explicit call What specifically is ugly on migration progress in status? What is "fast" about it? This change simplifies the whole flow significantly on the engine side as well so it should be pretty obvious how/why it was proposed. Would it be less ugly if we include such field all the time? If so it's fine with me, we anyway have other completely unused fields. Line 12: migrationStatus() for each VM. Line 13: Line 14: Signed-off-by: Peter V. Saveliev <[email protected]> -- To view, visit http://gerrit.ovirt.org/15125 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc32fa00eaa1b90c3ba9d0afffdeb1cdd8150f9a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
