Deepak C Shetty has posted comments on this change.
Change subject: image: add support to upload/download images
......................................................................
Patch Set 9: (1 inline comment)
....................................................
File vdsm/storage/image.py
Line 1162:
Line 1163: if template or len(chain) > 1:
Line 1164: self.log.error("Importing and exporting an image with
more "
Line 1165: "than one volume is not supported")
Line 1166: raise se.CopyImageError()
Why can't we use qemu-img convert to convert the chain into a qcow2/raw image
and then use it for upload/download ?
Line 1167:
Line 1168: domain.activateVolumes(imgUUID, volUUIDs=[chain[0].volUUID])
Line 1169: return chain[0]
Line 1170:
--
To view, visit http://gerrit.ovirt.org/14955
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib208bb20d88633167b5c66b42febe912439a022d
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
