Dan Kenigsberg has posted comments on this change. Change subject: vm: catch getVolumeSize failures in _normalizeVdsmImg ......................................................................
Patch Set 3: (1 inline comment) .................................................... File vdsm/vm.py Line 1738: drv['device'] = 'disk' Line 1739: Line 1740: if drv['device'] == 'disk': Line 1741: res = self.cif.irs.getVolumeSize(drv['domainID'], drv['poolID'], Line 1742: drv['imageID'], drv['volumeID']) Wouldn't it be better to check res['code'] for other modes of failure, and/or raise res['message'], instead of assuming it is a problem of the volume? Yeah, I know that this try-except block is my own 3 months old suggestion... Still, my question stands. Line 1743: try: Line 1744: drv['truesize'] = res['truesize'] Line 1745: drv['apparentsize'] = res['apparentsize'] Line 1746: except KeyError: -- To view, visit http://gerrit.ovirt.org/13529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8e170a85100e57d7e644614a21038d869777b82 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
