Michal Skrivanek has posted comments on this change.
Change subject: vdsm: pre-defined range for spice/vnc ports
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File lib/vdsm/tool/libvirt_configure.sh.in
Line 217: set_if_default "${lconf}" listen_tcp 1
Line 218: set_if_default "${lconf}" listen_tls 0
Line 219: fi
Line 220:
Line 221: # Configure remote display port range according to our docs
I was suggesting a different range in the bug. I think we have to do that to
not introduce issues since we're by default starting at 5900 ever since 2.3
Line 222: set_if_default "${qconf}" remote_display_port_min 5634
Line 223: set_if_default "${qconf}" remote_display_port_max 6166
Line 224:
Line 225: # Configuring sanlock
--
To view, visit http://gerrit.ovirt.org/17058
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id42d41064e122f1b2dcc98506b58d0cc74239650
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
