Alon Bar-Lev has posted comments on this change. Change subject: vdsmd and supervdsmd: extract common init tasks and add init adapter ......................................................................
Patch Set 8: (1 inline comment) .................................................... File vdsm/daemonAdapter Line 47: parser.add_argument( Line 48: '--target-option', dest='targetOption', default=list(), Line 49: metavar='target_opt0,target_opt1,...', action='append', Line 50: help='Add comma seperated options to be passed to target, multiple ' Line 51: 'occurrences of "--target-option opt" accumulates the options') just a thought... why not use the arguments (not options) as transparent? adapter --option=value --option=value program arguments Line 52: args = parser.parse_args(sys.argv[1:]) Line 53: return args Line 54: Line 55: -- To view, visit http://gerrit.ovirt.org/15578 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8e514df1ca88500f746242134ddb24c31588046 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
