Dan Kenigsberg has posted comments on this change.
Change subject: image: shrink the new volume When merging block cow volumes
......................................................................
Patch Set 8: (2 inline comments)
....................................................
File lib/vdsm/qemuImg.py
Line 96:
Line 97: cmd.append(image)
Line 98: rc, out, err = utils.execCmd(cmd)
Line 99:
Line 100: #FIXME: filter other rc as well
a comment should end guessworking, not initiate it.
Line 101: if rc != 0:
Line 102: raise QImgError(rc, out, err)
Line 103: try:
Line 104: check = {
Line 103: try:
Line 104: check = {
Line 105: 'offset': int(__iregexSearch("offset", out[1]))
Line 106: }
Line 107: except:
Which qemu version started to support 'offset'? It would be more to the oVirt
character to simply require that qemu version.
Line 108: raise QImgError(rc, out, err, "unable to parse qemu-img check
output")
Line 109:
Line 110: return check
Line 111:
--
To view, visit http://gerrit.ovirt.org/9725
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ace4c48d278cb84ce871bc402643131265c3198
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
