Martin Sivák has posted comments on this change. Change subject: vdsm: Reboot capability for VM ......................................................................
Patch Set 13: I would prefer that you didn't submit this (1 inline comment) .................................................... File lib/vdsm/utils.py Line 959: Line 960: # intentionally long name for the timeout arg to decrease the probability Line 961: # of conflicting with a kwarg called 'timeout' Line 962: def _addCallback(self, func, next_callback_timeout, *args, **kwargs): Line 963: self.callbacks.append((func, next_callback_timeout, args, kwargs)) Sorry about this, I should have told you in the previous patchset. Make this a namedtuple please. Line 964: Line 965: ## abstract methods to be overriden by descendants Line 966: Line 967: def _checkSuccess(self): -- To view, visit http://gerrit.ovirt.org/15829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
