Antoni Segura Puimedon has posted comments on this change.
Change subject: netconf: make ifcfg's rollback cover new added networks
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
There's a use case that we have to cover (commented it inline).
....................................................
File vdsm/netconf/ifcfg.py
Line 343: for dev in reversed(changed):
Line 344: ifdown(dev)
Line 345:
Line 346: def _startAtomicDevices(self):
Line 347: for dev in self._sortModifiedIfcfgs()[0]:
We are supposed to leave the nics and bonds up after removing the
configuration. Thus, an iteration and check like that of liknes 338-339 would
be needed.
Line 348: try:
Line 349: ifup(dev)
Line 350: except ConfigNetworkError:
Line 351: logging.error('Failed to ifup device %s during
rollback.', dev,
--
To view, visit http://gerrit.ovirt.org/17214
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabcfb10119d303f81f505a6065e3139eddb3b049
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
