Antoni Segura Puimedon has posted comments on this change.
Change subject: configNetwork: remove the option implicitBonding
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
I still have to review that it doesn't break anything, but I found this small
typo.
....................................................
File vdsm/configNetwork.py
Line 389: bond = Bond.objectivize(bondName, configurator,
Line 390: bondAttrs.get('options'),
Line 391: bondAttrs.get('nics'), mtu=None,
Line 392: _netinfo=_netinfo,
Line 393: destoryOnRemoval='remove' in
bondAttrs)
This is a typo. It should read destroyOnRemoval.
Line 394: if 'remove' in bondAttrs:
Line 395: logger.debug("Removing bond %s with attributes %s",
bondName,
Line 396: bondAttrs)
Line 397: configurator.removeBond(bond)
--
To view, visit http://gerrit.ovirt.org/17215
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb6429a67d522e4a813494c45e90187d39fcdcd1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
