Eduardo has posted comments on this change.
Change subject: Make getRepoStats() a hsm method.
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File vdsm/storage/hsm.py
Line 2474: se.StoragePoolActionError("spUUID=%s" % spUUID))
Line 2475: vars.task.getSharedLock(STORAGE, spUUID)
Line 2476: pool = self.getPool(spUUID)
Line 2477: poolInfo = pool.getInfo()
Line 2478: doms = pool.getDomains()
Sadly, poolInfo.domains field contains the dictionary as a string (by
sp.domainListEncoder).
In order to get the dictionary and for the sake of simplicity and uniformity,
we call StoragePool.getDomains() which unfortunately may issue a new MD read.
"May the Cache be with you"
Line 2479: domInfo = self._getDomsStats(pool.domainMonitor, doms)
Line 2480: for sdUUID in doms.iterkeys():
Line 2481: if 'isoprefix' in domInfo[sdUUID] and
domInfo[sdUUID]['isoprefix']:
Line 2482: poolInfo['isoprefix'] =
domInfo[sdUUID]['isoprefix']
--
To view, visit http://gerrit.ovirt.org/14673
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0273611a23f29b5c6be0354a4c6b2d6526a9b574
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel Paikov <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
