Eduardo has posted comments on this change.
Change subject: More precise exception when multipath failed.
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/devicemapper.py
Line 34: devlinkPath = DMPATH_FORMAT % deviceMultipathName
Line 35: try:
Line 36: devStat = os.stat(devlinkPath)
Line 37: except OSError as e:
Line 38: raise OSError(errno.ENODEV, "%s: %s" % (deviceMultipathName,
e))
>>> try:
os.stat("nada")
except OSError as e:
s = "%s" % (e,)
t = "%s" % (e.message,)
>>> s
"[Errno 2] No such file or directory: 'nada'"
>>> t
''
Line 39: else:
Line 40: return "dm-%d" % os.minor(devStat.st_rdev)
Line 41:
Line 42:
--
To view, visit http://gerrit.ovirt.org/17145
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b87e8e91b838db2c8a98c9afbbc998e8f4c792a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Elad Ben Aharon <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
