Michal Skrivanek has posted comments on this change. Change subject: drop ominous log for libvirt errors ......................................................................
Patch Set 1: the point is we do want to see what error code libvirt is returning for debug purposes. We do not handle/capture that in vm.py in few places...probably elsewhere. Again, Vinzenz should comment on that, but even I can tell from my investigations it is helpful. We do see that often in virt flows because of lookupByUUID, and so I suppose it's a similar case with network flows...but unless we report the errcode in all places when libvirtconnection is used I think we need a debug info about what happened in libvirt. We often do not get complete/all logs so any info is helpful. From this POV it makes sense to me to keep this as a nonimportant debug-level log -- To view, visit http://gerrit.ovirt.org/17324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd2a53ffee7fb78cb1c8d171093e93e233ed5ad4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
