Giuseppe Vallarelli has uploaded a new change for review. Change subject: tests: setupNetworks with invalid params. ......................................................................
tests: setupNetworks with invalid params. Added four functional tests: * testSetupNetworksAddBadBondingName * testSetupNetworksAddBadBridgeName * testSetupNetworksAddBadNic * testSetupNetworksAddBadParams covering the behaviour of setupNetworks when providing invalid params for bonding, bridge, nics. Change-Id: Ic77b3a9c0d84e38e8b9060191b138c3e09104dc6 Signed-off-by: Giuseppe Vallarelli <[email protected]> --- M tests/functional/networkTests.py 1 file changed, 46 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/17435/1 diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py index 6f64872..648e0b9 100644 --- a/tests/functional/networkTests.py +++ b/tests/functional/networkTests.py @@ -376,3 +376,49 @@ bridged)) self.assertFalse( self.vdsm_net.vlanExists(nic + '.' + tag)) + + @permutations([[True], [False]]) + @RequireDummyMod + @ValidateRunningAsRoot + def testSetupNetworksAddBadBondingName(self, brdgd): + with dummyIf(1) as nics: + for badName in ('bond', 'bonda', 'bond0a', 'jamesbond007'): + status, msg = self.vdsm_net.setupNetworks({NETWORK_NAME: + dict(bond=badName, + bridged=brdgd)}, + {badName: + dict(nics=nics)}, + {}) + self.assertEqual(status, neterrors.ERR_BAD_BONDING, msg) + + @RequireDummyMod + @ValidateRunningAsRoot + def testSetupNetworksAddBadBridgeName(self): + with dummyIf(1) as nics: + attrs = dict(nic=nics[0], bridged=True) + status, msg = self.vdsm_net.setupNetworks({'---': attrs}, + {}, {}) + self.assertEqual(status, neterrors.ERR_BAD_BRIDGE, msg) + + @permutations([[True], [False]]) + def testSetupNetworksAddBadNic(self, bridged): + attrs = dict(nic='whatever', bridged=bridged) + status, msg = self.vdsm_net.setupNetworks({NETWORK_NAME: attrs}, + {}, {}) + + self.assertEqual(status, neterrors.ERR_BAD_NIC, msg) + + @permutations([[True], [False]]) + def testSetupNetworksAddBadParams(self, bridged): + attrs = dict(vlan=VLAN_ID, bridged=bridged) + status, msg = self.vdsm_net.setupNetworks({NETWORK_NAME: attrs}, + {}, {}) + + self.assertTrue(status != SUCCESS, msg) + + del attrs['vlan'] + attrs['bonding'] = 'nonexistingbond' + status, msg = self.vdsm_net.setupNetworks({NETWORK_NAME: attrs}, + {}, {}) + + self.assertTrue(status != SUCCESS, msg) -- To view, visit http://gerrit.ovirt.org/17435 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic77b3a9c0d84e38e8b9060191b138c3e09104dc6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
