Lee Yarwood has posted comments on this change.
Change subject: Add hostusbdirect hook to vdsm_hooks.
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm_hooks/hostusbdirect/before_vm_start.py
Line 97:
Line 98: for usb in os.environ['usbhostdirect'].split('&'):
Line 99: bus, device = usb.split(':')
Line 100: chown(bus, device)
Line 101: devices.append({'bus': bus, 'device': device})
Urgh my mistake, why I didn't just call add_device(bus, device) is beyond me.
I'll push a new version later today with this and a few other typos changed.
Line 102:
Line 103: add_devices(domxml, devices)
Line 104: hooking.write_domxml(domxml)
Line 105: except:
--
To view, visit http://gerrit.ovirt.org/17428
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I00b4b03993cd7290462b0e17457892b23dd41b31
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Lee Yarwood <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
