Dan Kenigsberg has posted comments on this change. Change subject: Changing libvirt configure print ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) .................................................... File lib/vdsm/tool/libvirt_configure.sh.in Line 280: case "$1" in Line 281: reconfigure) Line 282: echo "Configuring libvirt for vdsm" Line 283: configure "$LCONF" "$QCONF" "$LDCONF" "$QLCONF" "$2" Line 284: echo "Done configuring" I do not like this line at all (also the original one). On most cases, where libvirt is already configured we see Configuring libvirt for vdsm Done configuring libvirt is already configured for vdsm which confuses me every time since it was introduced. Line 285: RETVAL=$? Line 286: ;; Line 287: test_conflict_configurations) Line 288: echo "Checking conflicts ..." -- To view, visit http://gerrit.ovirt.org/17296 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I081a5f8f13eb035994179174c976b2c2b629b74d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
