Giuseppe Vallarelli has posted comments on this change. Change subject: tests: addNetwork with one or more vlans. ......................................................................
Patch Set 2: (3 inline comments) .................................................... File tests/functional/networkTests.py Line 257: @cleanupNet Line 258: @permutations([[True], [False]]) Line 259: @RequireDummyMod Line 260: @ValidateRunningAsRoot Line 261: def testAddNetworkManyVlans(self, brdgd): Done Line 262: with dummyIf(1) as nics: Line 263: VLAN_COUNT = 5 Line 264: NET_VLANS = [(NETWORK_NAME + str(id), str(id)) Line 265: for id in xrange(VLAN_COUNT)] Line 260: @ValidateRunningAsRoot Line 261: def testAddNetworkManyVlans(self, brdgd): Line 262: with dummyIf(1) as nics: Line 263: VLAN_COUNT = 5 Line 264: NET_VLANS = [(NETWORK_NAME + str(id), str(id)) Done Line 265: for id in xrange(VLAN_COUNT)] Line 266: for net_vlan, vlan_id in NET_VLANS: Line 267: status, msg = self.vdsm_net.addNetwork(net_vlan, Line 268: vlan=vlan_id, Line 261: def testAddNetworkManyVlans(self, brdgd): Line 262: with dummyIf(1) as nics: Line 263: VLAN_COUNT = 5 Line 264: NET_VLANS = [(NETWORK_NAME + str(id), str(id)) Line 265: for id in xrange(VLAN_COUNT)] Done Line 266: for net_vlan, vlan_id in NET_VLANS: Line 267: status, msg = self.vdsm_net.addNetwork(net_vlan, Line 268: vlan=vlan_id, Line 269: nics=nics, -- To view, visit http://gerrit.ovirt.org/17376 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0de5f07bf93fbffca11abce000217c5155177e77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
