Ayal Baron has posted comments on this change.
Change subject: Make lvm.listPVNames() be based on vgs information.
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
....................................................
File vdsm/storage/lvm.py
Line 392: vgsFields = {}
Line 393: for line in out:
Line 394: fields = [field.strip() for field in
line.split(SEPARATOR)]
Line 395: uuid = fields[VG._fields.index("uuid")]
Line 396: pvNameIdx = VG._fields.index("pv_name")
nit: you can move this out of the for loop
Line 397: pv_name = fields[pvNameIdx]
Line 398: if uuid not in vgsFields:
Line 399: fields[pvNameIdx] = [pv_name] # Make a pv_names
list
Line 400: vgsFields[uuid] = fields
Line 393: for line in out:
Line 394: fields = [field.strip() for field in
line.split(SEPARATOR)]
Line 395: uuid = fields[VG._fields.index("uuid")]
Line 396: pvNameIdx = VG._fields.index("pv_name")
Line 397: pv_name = fields[pvNameIdx]
nm, got it
Line 398: if uuid not in vgsFields:
Line 399: fields[pvNameIdx] = [pv_name] # Make a pv_names
list
Line 400: vgsFields[uuid] = fields
Line 401: else:
--
To view, visit http://gerrit.ovirt.org/14631
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e04a73476cab53e9a0a6c74eab2e747380f25c4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel Paikov <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Elad Ben Aharon <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
