Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: Always retrieve alias for Balloon and Console devices ......................................................................
vdsm: Always retrieve alias for Balloon and Console devices We haven't been retrieving the alias value for console devices which now starts to bite us due to the assumption that all VmDevice objects, have to have an alias attribute during the migration. Due to a bug in the handling for Balloon devices this also happened. This commit fixes the problem for the future by retrieving the aliases. Change-Id: Ic828d13761b26b3ec01b604f431050a611bce01c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=988065 Signed-off-by: Vinzenz Feenstra <[email protected]> Reviewed-on: http://gerrit.ovirt.org/17602 Reviewed-by: Dan Kenigsberg <[email protected]> --- M vdsm/vm.py 1 file changed, 29 insertions(+), 7 deletions(-) Approvals: Vinzenz Feenstra: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic828d13761b26b3ec01b604f431050a611bce01c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
