Vinzenz Feenstra has posted comments on this change. Change subject: vdsm: Refactoring of retrieving device info from xml ......................................................................
Patch Set 2: (1 comment) There's a reason for having the parameter. You can pass an arbitrary passed XML. Before it always used the stored one. If we want to retrieve the information from a different XML (e.g. conf['_srcDomXML'] during an incoming migratoin we'd have otherwise to set the value internally to lastParsedXMlDesc which I don't think is a good idea. Besides that is my plan to move the getUnderlying*DeviceInfo to the dedicated device classes .................................................... File vdsm/vm.py Line 2730: def _getUnderlyingVmDevicesInfo(self): Line 2731: """ Line 2732: Obtain underlying vm's devices info from libvirt. Line 2733: """ Line 2734: devicesXml = self._getDevicesXml(parsedXml=self._lastParsedXmlDesc) In this case yes, I will fix this Line 2735: self._getUnderlyingNetworkInterfaceInfo(devicesXml=devicesXml) Line 2736: self._getUnderlyingDriveInfo(devicesXml=devicesXml) Line 2737: self._getUnderlyingDisplayPort(xml=self._lastParsedXmlDesc) Line 2738: self._getUnderlyingSoundDeviceInfo(devicesXml=devicesXml) -- To view, visit http://gerrit.ovirt.org/17694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
