Giuseppe Vallarelli has posted comments on this change. Change subject: lint: providing a default pylintrc ......................................................................
Patch Set 1: (4 comments) .................................................... File pylintrc Line 49: #enable-msg= Line 50: Line 51: # Disable the message(s) with the given id(s). Line 52: disable-msg=C0323,W0142,C0301,C0103,C0111,E0213,C0302,C0203,W0703,R0201,W0613,W0612,W0622 Line 53: Here what is disabled is the message. I'll add it. We might need to decide which checks we need to disable. Line 54: Line 55: [REPORTS] Line 56: Line 57: # set the output format. Available formats are text, parseable, colorized and Line 173: # generator expression variable names Line 174: inlinevar-rgx=[A-Za-z_][A-Za-z0-9_]*$ Line 175: Line 176: # Good variable names which should always be accepted, separated by a comma Line 177: good-names=i,j,k,ex,Run,_ Done Line 178: Line 179: # Bad variable names which should always be refused, separated by a comma Line 180: bad-names=foo,bar,baz,toto,tutu,tata Line 181: Line 179: # Bad variable names which should always be refused, separated by a comma Line 180: bad-names=foo,bar,baz,toto,tutu,tata Line 181: Line 182: # List of builtins function names that should not be used, separated by a comma Line 183: bad-functions=apply,input Done Line 184: Line 185: Line 186: # checks for sign of poor/misdesign: Line 187: # * number of methods, attributes, local variables... Line 213: # Minimum number of public methods for a class (see R0903). Line 214: min-public-methods=0 Line 215: Line 216: # Maximum number of public methods for a class (see R0904). Line 217: max-public-methods=20 We can disable some checks on specific modules with a comment in the format: # pylint: disable=W0401, E0202. I'll provide an example in API.py Line 218: Line 219: Line 220: # checks for Line 221: # * external modules dependencies -- To view, visit http://gerrit.ovirt.org/17772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia41d2bf225e0b5e47a0e2718b906fbd44f5a54e9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
