Yaniv Bronhaim has posted comments on this change. Change subject: Management network is now kept in main routing table ......................................................................
Patch Set 1: (4 comments) .................................................... File vdsm/configNetwork.py Line 45: def objectivizeNetwork(bridge=None, vlan=None, bonding=None, Line 46: bondingOptions=None, nics=None, mtu=None, ipaddr=None, Line 47: netmask=None, gateway=None, bootproto=None, Line 48: _netinfo=None, configurator=None, blockingdhcp=None, Line 49: implicitBonding=None, defaultRoute=None, **opts): shouldn't the default val be True\False? Line 50: """ Line 51: Constructs an object hierarchy that describes the network configuration Line 52: that is passed in the parameters. Line 53: .................................................... File vdsm/netconf/ifcfg.py Line 542: bootproto, mtu, defaultRoute, **opts) Line 543: Line 544: @staticmethod Line 545: def _getIfaceConfValues(iface, _netinfo): Line 546: ipaddr, netmask, gateway, bootproto, _, defaultRoute =\ should be 1 whitespace before the \ Line 547: iface.getIpConfig() Line 548: defaultRoute = ConfigWriter._toIfcfgFormat(defaultRoute) Line 549: mtu = iface.mtu Line 550: if _netinfo.ifaceUsers(iface.name): .................................................... File vdsm/netmodels.py Line 43: raise NotImplementedError Line 44: Line 45: def getIpConfig(self): Line 46: try: Line 47: ipaddr, netmask, gateway, bootproto, async, defaultRoute =\ pep8 stopped to yell about it, but i still used to whitespace after assignment character Line 48: self.ip.getConfig() Line 49: except AttributeError: Line 50: ipaddr = netmask = gateway = bootproto = async = defaultRoute =\ Line 51: None Line 333: ipaddr = self.inet.address Line 334: netmask = self.inet.netmask Line 335: gateway = self.inet.gateway Line 336: defaultRoute = self.inet.defaultRoute Line 337: except AttributeError: I would recommend for a log print here - using defaults when one of the parameters is not set. Edu doesn't like catching exceptions without raising\handling the reason for it. Line 338: ipaddr = netmask = gateway = defaultRoute = None Line 339: return ipaddr, netmask, gateway, self.bootproto, self.async,\ -- To view, visit http://gerrit.ovirt.org/17844 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55c50269dd3d52fd058951200282c925a7014aca Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Assaf Muller <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
