Antoni Segura Puimedon has posted comments on this change.
Change subject: tests: setupNetworks compatibility bond and nic.
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
....................................................
File tests/functional/networkTests.py
Line 304:
Line 305: # Try to add additional VLANed bridged network,
should fail
Line 306: netNameVlanBridged = NETWORK_NAME + '-5'
Line 307: networks['vlan'] = '200'
Line 308: networks['bridged'] = 'True'
True, not 'True'. Check what you do on line 292. It doesn't crash because we
use utils.tobool, but I'd rather have a proper boolean passed.
Line 309: status, msg =
self.vdsm_net.setupNetworks({netNameVlanBridged:
Line 310: networks},
{}, {})
Line 311: self.assertTrue(status != SUCCESS, msg)
Line 312:
--
To view, visit http://gerrit.ovirt.org/17621
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4a497d82723937dbecd14d42fc2c176c4c05bd2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
