Saggi Mizrahi has posted comments on this change.
Change subject: Only remove source routing if the ip configuration is down
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
....................................................
File vdsm/sourceRoute.py
Line 26: from vdsm import netinfo
Line 27: from vdsm.constants import P_VDSM_RUN
Line 28: from vdsm.ipwrapper import IPRoute2Error
Line 29: from vdsm.ipwrapper import Route
Line 30: from vdsm.ipwrapper import routeShowDev
from vdsm.ipwrapper import \
P_VDSM_RUN, \
IPRoute2Error. \
...
Line 31: from vdsm.ipwrapper import routeShowTable
Line 32: from vdsm.ipwrapper import Rule
Line 33: from vdsm.ipwrapper import ruleList
Line 34: from vdsm.utils import rmFile
Line 175:
Line 176: def remove(self):
Line 177: logging.info("Removing gateway - device: %s" % self.device)
Line 178:
Line 179: if routeShowDev(self.device):
Looks like something that should be done before remove(), or through an
exception or something else.
A remove() method that doesn't remove and doesn't complain about it sounds odd.
Line 180: # The host can receive dhcp release statements with FAIL
reason,
Line 181: # in which case the ip configuration is not deleted so
source
Line 182: # routing should not be deleted either
Line 183: logging.debug("DHCP release received but IP configuration
is"
--
To view, visit http://gerrit.ovirt.org/17950
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e31c5a1ddc8d514e8710a6aef2caee0e7276deb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
