Antoni Segura Puimedon has posted comments on this change. Change subject: hooks: macbind - This hook support binding specified mac address to custom/other bridge than the currently defined bridge in ovirt. This hook is also capable of binding a mac address to openvswitch bridge. ......................................................................
Patch Set 1: Code-Review-1 (3 comments) .................................................... Commit Message Line 3: AuthorDate: 2013-08-11 12:45:33 +0530 Line 4: Commit: Humble Chirammal <hchir...@redhat.com> Line 5: CommitDate: 2013-08-11 12:53:03 +0530 Line 6: Line 7: hooks: macbind - This hook support binding specified The first line should be a short summary, the explanation should be in another paragraph. Line 8: mac address to custom/other bridge than the currently defined Line 9: bridge in ovirt. This hook is also capable of binding Line 10: a mac address to openvswitch bridge. Line 11: .................................................... File vdsm_hooks/macbind/README Line 1: macbind vdsm hook: Line 2: ============ Line 3: This hook goes through all of the VM's interfaces and manipulate its Please, remove the line ending white spaces. Line 4: XML file acccording to the input. This can be used to attach a VM nic Line 5: to a specific bridge which is available in the hypervisor for 'that' VM run Line 6: or permanently. Line 7: Line 11: than the defined/default bridge for that NIC. Line 12: Line 13: Line 14: Syntax: Line 15: macbind=macaddress-brName-portType,... It should use the device properties like http://gerrit.ovirt.org/#/c/11108/11/vdsm_hooks/openstacknet/before_device_create.py does. Line 16: Line 17: where: Line 18: Line 19: macaddress: specify a macaddress which need to be attached to the VM -- To view, visit http://gerrit.ovirt.org/17895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0356dfab224a9082b44aae1c66df050f7456301c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: humble devassy <hchir...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Aravinda VK <avish...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
