Michal Skrivanek has posted comments on this change. Change subject: [WIP] vm: cleanup of vm.py ......................................................................
Patch Set 5: (1 comment) .................................................... File vdsm/vm.py Line 2832: # saving we will fail in inconsistent state during recovery. Line 2833: # So, to get proper device objects during VM recovery flow Line 2834: # we must to have updated conf before VM run Line 2835: self.saveState() Line 2836: else: well....leaving just a comment? Line 2837: # TODO: In recover should loop over disks running on the VM because Line 2838: # conf may be outdated if something happened during restart. Line 2839: Line 2840: # For BC we should to keep running VM run after vdsm upgrade. -- To view, visit http://gerrit.ovirt.org/18047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2712148b670c9f85beaea40a0b2e870d829b2b4b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpole...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
