Antoni Segura Puimedon has posted comments on this change.

Change subject: Functional Tests [1/3]: Added module for dummy nics
......................................................................


Patch Set 1:

(1 comment)

....................................................
File tests/functional/dummyUtils.py
Line 33:     in the format dummy_Number). Assumes root privileges.
Line 34:     """
Line 35: 
Line 36:     rc = -1
Line 37:     for i in random.sample(xrange(100), 100):
s/xrange/range/

I know it was on the original code. But since we are moving it, let's clean up 
a bit.
Line 38:         dummy_name = 'dummy_%s' % i
Line 39:         ip_add_dummy = [ip.cmd, 'link', 'add', dummy_name,
Line 40:                         'type', 'dummy']
Line 41:         rc, out, err = utils.execCmd(ip_add_dummy, sudo=True)


-- 
To view, visit http://gerrit.ovirt.org/18039
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c7ed4110cd8d45a3fb7a9cc2cd2dc07004e96b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to