Giuseppe Vallarelli has posted comments on this change.
Change subject: Introducing hidden_vlans configurable
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
....................................................
File lib/vdsm/netinfo.py
Line 140:
Line 141:
Line 142: def vlans():
Line 143: hidden_vlans = config.get('vars', 'hidden_vlans').split(',')
Line 144: return [b.split('/')[-1] for b in iglob('/sys/class/net/*.*')
Instead of b.split('/')[-1] can you use os.path.basename(b) ?
Line 145: if not _match_name(b.split('/')[-1], hidden_vlans)]
Line 146:
Line 147:
Line 148: def bridges():
--
To view, visit http://gerrit.ovirt.org/18082
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4340936fb998c5ab9ee46e16a16ae15461176f2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <[email protected]>
Gerrit-Reviewer: Amador Pahim <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
