Eduardo has posted comments on this change.

Change subject: Fix parentVolumeRollback function
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

....................................................
File vdsm/storage/volume.py
Line 334:                 pvol = sdCache.produce(sdUUID).produceVolume(pimgUUID,
Line 335:                                                              pvolUUID)
Line 336:                 pvol.prepare()
Line 337:                 if not pvol.isShared() and not pvol.recheckIfLeaf():
Line 338:                     pvol.setLeaf()
Failing to read/write volume metadata will leave the parent volume activated.
Line 339:                 pvol.teardown(sdUUID, pvolUUID)
Line 340:         except Exception:
Line 341:             cls.log.error("Unexpected error", exc_info=True)
Line 342: 


-- 
To view, visit http://gerrit.ovirt.org/18205
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11948aacad21008ffbb4cb23013bf363e60bdb9b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to