Antoni Segura Puimedon has posted comments on this change. Change subject: Change of ConfigWriter._createConfFile parameters ......................................................................
Patch Set 1: Code-Review-1 (1 comment) -1 for visibility of the question. .................................................... File vdsm/netconf/ifcfg.py Line 539: if not iface.mtu: Line 540: mtu = confParams.get('MTU', None) Line 541: if mtu: Line 542: mtu = int(mtu) Line 543: return iface.ip Shouldn't this be iface.ipConfig so that we just return the named tuple? Line 544: Line 545: def removeNic(self, nic): Line 546: cf = netinfo.NET_CONF_PREF + nic Line 547: self._backup(cf) -- To view, visit http://gerrit.ovirt.org/18331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae5ec15048ed52170371dda1d0fa9b90d51838e3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Ĺ ebek <pse...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches