Martin Polednik has posted comments on this change. Change subject: tests: vdsProxy remove need to duplicate api ......................................................................
Patch Set 1: (1 comment) .................................................... File tests/functional/utils.py Line 139: return result['status']['code'], result['status']['message'] Line 140: """ Line 141: if hasattr(self.vdscli, func): Line 142: def wrapper(*args, **kw): Line 143: result = getattr(self.vdscli, func)(*args, **kw) I kind of like that because it would eliminate even more code, but on the other hand it would negatively affect code - api calls from tests would have nonstandard arguments compared to calls from raw code, adding to confusion. It would be great to hear more opinions on this idea Line 144: return result['status']['code'], result['status']['message'] Line 145: return wrapper Line 146: raise AttributeError(func) Line 147: -- To view, visit http://gerrit.ovirt.org/18417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84d1e696a5280402725223ecc87646a75ba60061 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpole...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpole...@redhat.com> Gerrit-Reviewer: Mei Liu <liu...@linux.vnet.ibm.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
