Dan Kenigsberg has submitted this change and it was merged.
Change subject: fix getVlanID returning an int issues
......................................................................
fix getVlanID returning an int issues
The fact that getVlanId now returns an int causes issues across
the networking codebase due to the fact that there was a lot of
concatenation of the kind:
vlanDev = ifacename + '.' + vlanId
which of course causes a TypeError due to trying to concatenate
string and int.
Additionally, there was code like:
if (not) vlan:
which now that vlan is int, will be evaluated as False when we
use vlan with id 0.
Finally, this patch makes all internal dealings with vlan ids
to be converted to integer on reception.
Change-Id: I0221bd6ba573c564052bac468d119c2aaceef6e0
Signed-off-by: Antoni S. Puimedon <asegu...@redhat.com>
Reviewed-on: http://gerrit.ovirt.org/18449
Reviewed-by: Amador Pahim <apa...@redhat.com>
Reviewed-by: Dan Kenigsberg <dan...@redhat.com>
---
M vdsm/configNetwork.py
M vdsm/netmodels.py
2 files changed, 17 insertions(+), 6 deletions(-)
Approvals:
Antoni Segura Puimedon: Verified
Amador Pahim: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0221bd6ba573c564052bac468d119c2aaceef6e0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Amador Pahim <apa...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
