Giuseppe Vallarelli has posted comments on this change.
Change subject: Unified network persistence [3/3] - Restore network
configuration
......................................................................
Patch Set 4: Code-Review-1
(2 comments)
....................................................
File vdsm/vdsm-restore-net-config
Line 42: """
Line 43: nets = {}
Line 44: bonds = {}
Line 45: for netFile in os.listdir(netinfo.NET_CONF_PERS_DIR):
Line 46: nets[os.path.basename(netFile)] = json.load(open(
I think there is no need of os.path.basename here.
Line 47: netinfo.NET_CONF_PERS_DIR + netFile))
Line 48:
Line 49: for bondFile in os.listdir(netinfo.BOND_CONF_PERS_DIR):
Line 50: bonds[os.path.basename(bondFile)] = json.load(open(
Line 46: nets[os.path.basename(netFile)] = json.load(open(
Line 47: netinfo.NET_CONF_PERS_DIR + netFile))
Line 48:
Line 49: for bondFile in os.listdir(netinfo.BOND_CONF_PERS_DIR):
Line 50: bonds[os.path.basename(bondFile)] = json.load(open(
same as previously said.
Line 51: netinfo.BOND_CONF_PERS_DIR + bondFile))
Line 52:
Line 53: logging.debug("Calling setupNetworks with networks: %s, bondings:
%s" %
Line 54: (nets, bonds))
--
To view, visit http://gerrit.ovirt.org/17010
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Petr Šebek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
