Mark Wu has posted comments on this change. Change subject: Added required ipwrapper functions for iproute2 configurator ......................................................................
Patch Set 1: Code-Review-1 (1 comment) .................................................... File lib/vdsm/ipwrapper.py Line 265: command = [_IP_BINARY.cmd, 'addr', 'flush', 'dev', dev] Line 266: _execCmd(command) Line 267: Line 268: Line 269: def linkAdd(link=None, name=None, type=None, linkArgs=None): name and type is not optional, right? Line 270: command = [_IP_BINARY.cmd, 'link', 'add'] Line 271: if link: Line 272: command += ['link', link] Line 273: if name: -- To view, visit http://gerrit.ovirt.org/18585 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9283ae90f84fa930e401b3ecd2e18935ba9ca2f5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
