Yaniv Bronhaim has posted comments on this change.

Change subject: Remove vdsm directories on uninstallation
......................................................................


Patch Set 1: -Code-Review

(1 comment)

btw, what about all the hooks directories as %dir 
%{_libexecdir}/%{vdsm_name}/hooks, don't we need to remove those as well?

....................................................
File vdsm.spec.in
Line 794: %dir %attr(-, %{vdsm_user}, %{vdsm_group}) @vdsmrepo@
Line 795: %ghost %dir %attr(-, %{vdsm_user}, %{vdsm_group}) @vdsmrepo@/hsm-tasks
Line 796: %ghost %dir %attr(-, %{vdsm_user}, %{vdsm_group}) @vdsmrepo@/mnt
Line 797: %dir %{_libexecdir}/%{vdsm_name}
Line 798: %dir %{_datadir}/%{vdsm_name}
don't we need also:

%dir %{_datadir}/%{vdsm_name}/storage/protect
Line 799: %dir %{_datadir}/%{vdsm_name}/netconf
Line 800: %dir %{_datadir}/%{vdsm_name}/storage
Line 801: %dir %{_datadir}/%{vdsm_name}/storage/imageRepository
Line 802: %{_datadir}/%{vdsm_name}/alignmentScan.py*


-- 
To view, visit http://gerrit.ovirt.org/16764
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I119c691cfdf6a487f36aef6ab451073af0230143
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to