Dan Kenigsberg has posted comments on this change.
Change subject: Remove bonds before editing and adding
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
....................................................
File vdsm/configNetwork.py
Line 421: configurator.editBonding(bond, _netinfo)
Line 422: for name, attrs in addition:
Line 423: bond = Bond.objectivize(name, configurator,
attrs.get('options'),
Line 424: attrs.get('nics'), mtu=None,
_netinfo=_netinfo,
Line 425: destroyOnMasterRemoval='remove' in
attrs)
using a helper function could make sense - but that HAS to be a future patch to
master branch.
Line 426: logger.debug("Creating bond %r with options %s", bond,
bond.options)
Line 427: configurator.configureBond(bond)
Line 428:
Line 429:
--
To view, visit http://gerrit.ovirt.org/18587
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ea081fe7760b52f6febb4959f69851b2cf4c2a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
