Ayal Baron has posted comments on this change.
Change subject: Fix rollback after failure to create snapshot
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
....................................................
File vdsm/storage/volume.py
Line 329: pvolUUID)
Line 330: pvol.prepare()
Line 331: try:
Line 332: if not pvol.recheckIfLeaf():
Line 333: pvol.setLeaf()
again, if recheckIfLeaf returns False then it is not safe to call it here and
if it is returning true then there is nothing left to do.
For example, in this flow you would change a shared volume into a leaf (i.e. a
template into a leaf).
Line 334: except Exception:
Line 335: cls.log.error("Unexpected error", exc_info=True)
Line 336: finally:
Line 337: pvol.teardown(sdUUID, pvolUUID)
--
To view, visit http://gerrit.ovirt.org/18205
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11948aacad21008ffbb4cb23013bf363e60bdb9b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
